ThaMunsta/whats-the-point
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

friend bugfix
All checks were successful
Build Images and Deploy / Update-PROD-Stack (push) Successful in 34s
Details

Browse Source
This commit is contained in:
Mike Johnston
2026-01-30 17:43:02 -05:00
parent 754badc60f
commit dbd9f89fbd
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
backend/src/routes/friends.js
View File

@@ -45,6 +45,11 @@ router.get('/', authMiddleware, asyncHandler(async (req, res) => {
); );
// Also get people who have shared challenges with me (auto-friends from challenges) // Also get people who have shared challenges with me (auto-friends from challenges)
// Build the NOT IN clause only if there are friends to exclude
const notInClause = friends.length > 0
? `AND u.id NOT IN (${friends.map(() => '?').join(',')})`
: '';
const challengeFriends = await query( const challengeFriends = await query(
`SELECT DISTINCT `SELECT DISTINCT
u.id, u.username, u.email, u.id, u.username, u.email,
@@ -66,7 +71,7 @@ router.get('/', authMiddleware, asyncHandler(async (req, res) => {
INNER JOIN challenges c ON cp.challenge_id = c.id INNER JOIN challenges c ON cp.challenge_id = c.id
WHERE c.created_by = ? AND cp.user_id != ? AND cp.status = 'accepted' WHERE c.created_by = ? AND cp.user_id != ? AND cp.status = 'accepted'
) )
AND u.id NOT IN (${friends.map(() => '?').join(',') || 'NULL'}) ${notInClause}
ORDER BY u.username`, ORDER BY u.username`,
[req.user.userId, req.user.userId, req.user.userId, req.user.userId, req.user.userId, req.user.userId, ...friends.map(f => f.id)] [req.user.userId, req.user.userId, req.user.userId, req.user.userId, req.user.userId, req.user.userId, ...friends.map(f => f.id)]
); );