From 26ca2ab90751b9e7dfda4ec66bdfba0909fc065d Mon Sep 17 00:00:00 2001
From: johnnyq <johnny@pittpc.com>
Date: Fri, 6 Dec 2024 16:10:56 -0500
Subject: [PATCH] Fix View After Delete and turn it into a switch

---
 ajax.php          |  2 +-
 js/share_modal.js |  4 ++--
 share_modal.php   | 36 ++++++++++++++++++------------------
 3 files changed, 21 insertions(+), 21 deletions(-)

diff --git a/ajax.php b/ajax.php
index 132ff249..de095c93 100644
--- a/ajax.php
+++ b/ajax.php
@@ -251,7 +251,7 @@ if (isset($_GET['share_generate_link'])) {
     $item_id = intval($_GET['id']);
     $item_email = sanitizeInput($_GET['contact_email']);
     $item_note = sanitizeInput($_GET['note']);
-    $item_view_limit = intval($_GET['views'] ?? 0);
+    $item_view_limit = intval($_GET['views']);
     $item_expires = sanitizeInput($_GET['expires']);
     $item_expires_friendly = "never"; // default never
     if ($item_expires == "1 HOUR") {
diff --git a/js/share_modal.js b/js/share_modal.js
index bb9c3a4d..4ae2ead3 100644
--- a/js/share_modal.js
+++ b/js/share_modal.js
@@ -27,12 +27,12 @@ function generateShareLink() {
     let item_type = document.getElementById("share_item_type").value;
     let item_ref_id = document.getElementById("share_item_ref_id").value;
     let item_note = document.getElementById("share_note").value;
-    let item_views = document.getElementById("share_views").value;
+    let item_views = document.getElementById("share_views").checked ? 1 : 0;
     let item_expires = document.querySelector('input[name="expires"]:checked').value;
     let contact_email = document.getElementById("share_email").value;
 
     // Check values are provided
-    if (item_views && item_expires) {
+    if (item_expires) {
         // Send a GET request to ajax.php as ajax.php?share_generate_link=true....
         jQuery.get(
             "ajax.php",
diff --git a/share_modal.php b/share_modal.php
index 1897b43f..d9963ed7 100644
--- a/share_modal.php
+++ b/share_modal.php
@@ -44,27 +44,27 @@
                         
                         <label>Expiration</label>
                         <div class="form-group">
-                            <div class="input-group">
-                                <div class="btn-group btn-block btn-group-toggle" data-toggle="buttons">
-                                    <label class="btn btn-outline-dark active">
-                                        <input type="radio" name="expires" value="1 HOUR" checked>1 hour
-                                    </label>
-                                    <label class="btn btn-outline-dark">
-                                        <input type="radio" name="expires" value="24 HOUR">1 day
-                                    </label>
-                                    <label class="btn btn-outline-dark">
-                                        <input type="radio" name="expires" value="168 HOUR">1 week
-                                    </label>
-                                    <label class="btn btn-outline-dark">
-                                        <input type="radio" name="expires" value="730 HOUR">1 month
-                                    </label>
-                                </div>
+                            <div class="btn-group btn-block btn-group-toggle" data-toggle="buttons">
+                                <label class="btn btn-outline-dark active">
+                                    <input type="radio" name="expires" value="1 HOUR" checked>1 hour
+                                </label>
+                                <label class="btn btn-outline-dark">
+                                    <input type="radio" name="expires" value="24 HOUR">1 day
+                                </label>
+                                <label class="btn btn-outline-dark">
+                                    <input type="radio" name="expires" value="168 HOUR">1 week
+                                </label>
+                                <label class="btn btn-outline-dark">
+                                    <input type="radio" name="expires" value="730 HOUR">1 month
+                                </label>
                             </div>
                         </div>
 
-                        <div class="form-group form-check">
-                            <input type="checkbox" class="form-check-input" name="views" id="share_views" value="1">
-                            <label class="form-check-label text-secondary">Delete after viewing</label>
+                        <div class="form-group">
+                            <div class="custom-control custom-switch">
+                                <input type="checkbox" class="custom-control-input" name="views" id="share_views" value="1">
+                                <label class="custom-control-label" for="share_views">Delete after view</label>
+                            </div>
                         </div>
 
                         <div class="form-group">