Better error handling for undefined/non-existent asset IDs

This commit is contained in:
wrongecho
2025-11-02 17:12:03 +00:00
parent d3d706ea68
commit 215eadcf2b

View File

@@ -21,8 +21,14 @@ if (isset($_GET['asset_id'])) {
LEFT JOIN asset_interfaces ON interface_asset_id = asset_id AND interface_primary = 1 LEFT JOIN asset_interfaces ON interface_asset_id = asset_id AND interface_primary = 1
WHERE asset_id = $asset_id WHERE asset_id = $asset_id
$client_query $client_query
LIMIT 1
"); ");
if (mysqli_num_rows($sql) == 0) {
echo "<center><h1 class='text-secondary mt-5'>Nothing to see here</h1><a class='btn btn-lg btn-secondary mt-3' href='tickets.php'><i class='fa fa-fw fa-arrow-left'></i> Go Back</a></center>";
} else {
$row = mysqli_fetch_array($sql); $row = mysqli_fetch_array($sql);
$client_id = intval($row['client_id']); $client_id = intval($row['client_id']);
$client_name = nullable_htmlentities($row['client_name']); $client_name = nullable_htmlentities($row['client_name']);
@@ -1177,7 +1183,7 @@ if (isset($_GET['asset_id'])) {
?> ?>
<script> <script>
function updateAssetNotes(asset_id) { function updateAssetNotes(asset_id) {
var notes = document.getElementById("assetNotes").value; var notes = document.getElementById("assetNotes").value;
@@ -1191,10 +1197,10 @@ if (isset($_GET['asset_id'])) {
} }
) )
} }
</script> </script>
<!-- JavaScript to Show/Hide Password Form Group --> <!-- JavaScript to Show/Hide Password Form Group -->
<script> <script>
$(document).ready(function() { $(document).ready(function() {
$('.authMethod').on('change', function() { $('.authMethod').on('change', function() {
var $form = $(this).closest('.authForm'); var $form = $(this).closest('.authForm');
@@ -1206,23 +1212,25 @@ if (isset($_GET['asset_id'])) {
}); });
$('.authMethod').trigger('change'); $('.authMethod').trigger('change');
}); });
</script> </script>
<!-- Include script to get TOTP code via the credential ID --> <!-- Include script to get TOTP code via the credential ID -->
<script src="js/credential_show_otp_via_id.js"></script> <script src="js/credential_show_otp_via_id.js"></script>
<script src="../js/bulk_actions.js"></script> <script src="../js/bulk_actions.js"></script>
<?php <?php
require_once "modals/asset/asset_interface_add.php"; require_once "modals/asset/asset_interface_add.php";
require_once "modals/asset/asset_interface_multiple_add.php"; require_once "modals/asset/asset_interface_multiple_add.php";
require_once "modals/asset/asset_interface_import.php"; require_once "modals/asset/asset_interface_import.php";
require_once "modals/asset/asset_interface_export.php"; require_once "modals/asset/asset_interface_export.php";
require_once "modals/ticket/ticket_add.php"; require_once "modals/ticket/ticket_add.php";
require_once "modals/recurring_ticket/recurring_ticket_add.php"; require_once "modals/recurring_ticket/recurring_ticket_add.php";
require_once "modals/credential/credential_add.php"; require_once "modals/credential/credential_add.php";
require_once "modals/document/document_add.php"; require_once "modals/document/document_add.php";
require_once "modals/file/file_upload.php"; require_once "modals/file/file_upload.php";
}
require_once "../includes/footer.php"; require_once "../includes/footer.php";